Add function to sketch arc given end point and radius#1705
Open
spike77453 wants to merge 1 commit intoCadQuery:masterfrom
Open
Add function to sketch arc given end point and radius#1705spike77453 wants to merge 1 commit intoCadQuery:masterfrom
spike77453 wants to merge 1 commit intoCadQuery:masterfrom
Conversation
spike77453
force-pushed
the
feature_add_arc_by_point_and_radius
branch
from
40cae35 to
68e08fa
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1705 +/- ##
==========================================
+ Coverage 95.29% 95.73% +0.44%
==========================================
Files 27 28 +1
Lines 6712 9458 +2746
Branches 1001 1625 +624
==========================================
+ Hits 6396 9055 +2659
- Misses 193 242 +49
- Partials 123 161 +38 ☔ View full report in Codecov by Sentry. |
Member
|
@spike77453 are you willing to add some tests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a function to sketch an arc given only the end point and the arc's radius.
The start point of the arc is assumed to be
self._endPoint()of the sketch. A third point on the arc (the arc's midpoint) is constructed by creating a vector rectangular to the arc's cord with magnitude equal to the sagitta of the arc, added to the midpoint of the arc's cord (see https://math.stackexchange.com/a/3482681).Edge.makeThreePointArcis used to create the arc with these three point.